Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Docs: Fix SE Health endpoint path to match code snippet #8587

Merged
merged 1 commit into from Mar 29, 2024

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Mar 29, 2024

Description

Corrects SE health endpoint path in text to match example code snippet.

Fixes #8485

Documentation

Fixes documentation

@barchetta barchetta self-assigned this Mar 29, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 29, 2024
@barchetta barchetta requested a review from tjquinno March 29, 2024 15:28
tjquinno
tjquinno previously approved these changes Mar 29, 2024
@barchetta
Copy link
Member Author

barchetta commented Mar 29, 2024

Ooops! I think the bug wants the fix the other way around (leave snippet, change text). Fixed with below commit.

@barchetta barchetta changed the title Fix SE Health endpoint path in example code Fix SE Health endpoint path to match code snippet Mar 29, 2024
@barchetta barchetta changed the title Fix SE Health endpoint path to match code snippet 4.x: Docs: Fix SE Health endpoint path to match code snippet Mar 29, 2024
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove /observe? That's the default, unless changed.

docs/src/main/asciidoc/se/health.adoc Show resolved Hide resolved
@barchetta barchetta merged commit f5ca2ba into helidon-io:main Mar 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x docs health OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x: docs se/health k8s example snippet wrong annotations
2 participants