4.x: Proper handling of invalid Accept types #8669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to parse any Accept header type, immediately return a 406 Not Acceptable error code.
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
previously approved these changes
Apr 17, 2024
barchetta
reviewed
Apr 17, 2024
...bserve/metrics/src/test/java/io/helidon/webserver/observe/metrics/TestInvalidAcceptType.java
Show resolved
Hide resolved
…ust metrics endpoints. Uses 400 Bad Request for both cases now. New tests.
spericas
changed the title
spericas
changed the title
tjquinno
approved these changes
Apr 17, 2024
barchetta
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proper handling of invalid Accept types. If unable to parse any Accept header type, returns a 400 Bad Request error. See issue #8666.
Documentation
None