4.x: Add todo for duplicates in CompositeArrayBufferData and CompositeListBufferData #8888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
TODO in code should not be used. We may have some, but it is a bug, not a feature. |
|
Also this code seems to be a duplicate, but it is not, as |
|
@tomas-langer Thank you for the explanation. Then I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've found, that there are many duplicated methods in
CompositeArrayBufferDataandCompositeListBufferDataFor example
writeTo(ByteBuffer writeBuffer, int limit)Maybe I should create the issue, but I'm not sure. The todo can be useful.