Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footers, recover-password page, add background-video #12

Closed
wants to merge 5 commits into from
Closed

Conversation

akhlopiachyi
Copy link
Contributor

No description provided.

Copy link

@mod mod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes are not going in the right direction, instead of fixing the template with light fixes, we drifting heavily away

@@ -166,4 +166,5 @@
</div>
</div>
</div>
${require('./layouts/footer.html')}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure agency has no footer ?

</a>
<i class="ion-social-twitter">

</i>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix properly icons

@@ -60,8 +59,7 @@
<img src="/images/uifaces/9.jpg" class="avatar">
By <span>Christopher Waltz</span>
</div>
<a href="#">
<img class="bg" src="/images/unsplash/photo-1470753937643-efeb931202a9.jpg"/>
<a href="#" class="bg" style="background-image:url('images/unsplash/photo-1470753937643-efeb931202a9.jpg');">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the correct require;

@@ -127,4 +127,4 @@
</div>


${require('./layouts/footer.html')}
${require('./layouts/footer-blog.html')}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this page is not related to blog
I don't like the name of the footer.
maybe it's a footer-light ? or footer-simple ?
what is different with standard footer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standart footer was footer-big-menu, but we need to have footer-blog(i changed it on footer-dark)

@@ -1,5 +1,269 @@
<!doctype html>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you don't use the dark-header and footer here

@@ -132,7 +132,7 @@
<div class="index-photography-footer" id="contact">
<div class="footer-wrapper skrollr"
data-200-top="transform: translateY(-120px);box-shadow: 0px 55px 60px rgba(0,0,0,0.3);"
data-bottom="transform: translateY(-40px);box-shadow: 0px 0px 0px rgba(0,0,0,0.3);">
data-bottom="transform: translateY(-40px);box-shadow: 0px 0px 0px rgba(0,0,0,0.3);" style="transform: translateY(-120px); box-shadow: 0px 55px 60px rgba(0,0,0,0.3);">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rejected, we don't write style="" anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants