Updated pwr.p.test #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
Changed the upper limit of n from 5 to 9 digits, for the function to be able to work in situations where n is greater than or equal to 100,000 (lines 52-53). I verified that the program didn't take any longer than it did when the upper limit was 5 digits. For internet-scale testing, it's frequently the case that the effect size is very small, and the number of observations required is larger than 100,000. For example, for p0=5% and p1=5.15%, the number of observations required is 132367. Small effects like this over large populations are especially common in e-commerce, search, and advertising. The legacy function returns an error in such situations because the search space for n is limited to 100,000. This change increases the search interval for sample size to 10 million, to account for these sorts of scenarios.
|
Thanks for the contribution. Would you be willing to revise the upper limit of |
Increased the limit for n
increased limit for n
|
Am working on changing the upper limit of n for the rest of the functions at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the upper limit of n from 5 to 9 digits, for the function to be able to work in situations where n is greater than or equal to 100,000 (lines 52-53). I verified that the program didn't take any longer than it did when the upper limit was 5 digits. For internet-scale testing, it's frequently the case that the effect size is very small, and the number of observations required is larger than 100,000. For example, for p0=5% and p1=5.15%, the number of observations required is 132367. Small effects like this over large populations are especially common in e-commerce, search, and advertising. The legacy function returns an error in such situations because the search space for n is limited to 100,000. This change increases the search interval for sample size to 10 million, to account for these sorts of scenarios.