Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP 51 updates – 5/3 #397

Merged
merged 5 commits into from
May 4, 2022
Merged

HIP 51 updates – 5/3 #397

merged 5 commits into from
May 4, 2022

Conversation

shayons297
Copy link
Contributor

@abhay
Copy link
Contributor

abhay commented May 3, 2022

Rendered link: https://github.com/shayons297/HIP/blob/patch-18/0051-helium-dao.md

@shayons297
Updated 7:34PM
27e3867 
Updated 7:34PM helium#336
shayons297
shayons297 commented May 3, 2022
View reviewed changes
Copy link
Contributor Author

@shayons297 shayons297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final version

abhay
abhay reviewed May 4, 2022
View reviewed changes
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md Outdated Show resolved Hide resolved
0051-helium-dao.md
The address **relays the message of the sale to the set of DNP Validators**,
which then adjust the position of the Programmatic Treasury in the following epoch after
adjusting for all other sales and any new issuance.
![https://lh6.googleusercontent.com/6boBre9RQbrytVAu-kKZgqimQ-d5n19SUbw8IOkJDnlaazep_4dTn2yRHU_TGw_zYtbizMYWUY5k8ODeO7MiPNgXslJcOygxBICiVdB4NpzxstK0Cb5wuaK1LEpLsLyj68bWe1KIfkmiOz7ejQ](https://lh6.googleusercontent.com/6boBre9RQbrytVAu-kKZgqimQ-d5n19SUbw8IOkJDnlaazep_4dTn2yRHU_TGw_zYtbizMYWUY5k8ODeO7MiPNgXslJcOygxBICiVdB4NpzxstK0Cb5wuaK1LEpLsLyj68bWe1KIfkmiOz7ejQ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this diagram is a little confusing. specifically the transfer between end user and hotspot.

@jamiew jamiew changed the title 5/3 HIP 51 updates – 5/3 May 4, 2022
@jamiew
Copy link
Contributor

jamiew commented May 4, 2022

@shayons297 I defer to you as far as merging @abhay's comments. All look good on my quick scan.

did you want to see these updates merged prior to community call today? (in 2 hours)

@jamiew jamiew added the updates edits/updates to an existing HIP label May 4, 2022
@shayons297
Copy link
Contributor Author

Yes, I believe this is ready to merge.

@jamiew @abhay
Apply @abhay suggestions from code review
91b95fe 
Using GitHub's fancy new bulk commit suggestions; let's see if this works.

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
@jamiew
Copy link
Contributor

jamiew commented May 4, 2022

FYI I bulk-merged @abhay's suggestions in 91b95fe

abhay
abhay reviewed May 4, 2022
View reviewed changes
0051-helium-dao.md Outdated Show resolved Hide resolved
abhay
abhay reviewed May 4, 2022
View reviewed changes
0051-helium-dao.md Outdated Show resolved Hide resolved
@jamiew jamiew merged commit 05299ee into helium:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhay abhay abhay left review comments

Assignees
No one assigned
Labels
updates edits/updates to an existing HIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shayons297 @abhay @jamiew