Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Add packet hash to state channel rejection #1035

Merged
merged 2 commits into from Oct 7, 2021
Merged

Add packet hash to state channel rejection #1035

merged 2 commits into from Oct 7, 2021

Conversation

madninja
Copy link
Member

@madninja madninja commented Oct 7, 2021

No description provided.

madninja
madninja commented Oct 7, 2021
View reviewed changes
rebar.config Outdated Show resolved Hide resolved
@madninja madninja requested a review from macpie October 7, 2021 15:07
Vagabond
Vagabond approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@Vagabond Vagabond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right to me.

macpie
macpie approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@macpie macpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably improve the queue in handlers to be a map now that we have packet hash for both purchase and rejection

@madninja madninja merged commit 3bb2fc7 into master Oct 7, 2021
@madninja madninja deleted the madninja/rejection_packet_hash branch October 7, 2021 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Vagabond Vagabond Vagabond approved these changes

@macpie macpie macpie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@madninja @Vagabond @macpie