Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

try not to re-validate txns in blocks that we've signed #337

Merged
merged 1 commit into from Jan 9, 2020

Conversation

evanmcc
Copy link
Contributor

@evanmcc evanmcc commented Jan 9, 2020

No description provided.

@evanmcc evanmcc requested a review from Vagabond January 9, 2020 00:38
@Vagabond Vagabond force-pushed the pevm/dont-validate-selfsigned-blocks branch from 703b034 to d15a318 Compare January 9, 2020 01:28
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #337 into master will decrease coverage by 3.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   68.31%   65.28%   -3.03%     
==========================================
  Files          67       67              
  Lines        6518     6534      +16     
==========================================
- Hits         4453     4266     -187     
- Misses       2065     2268     +203
Impacted Files Coverage Δ
src/blockchain.erl 68.17% <100%> (+0.76%) ⬆️
.../transactions/v1/blockchain_txn_redeem_htlc_v1.erl 38.46% <0%> (-41.54%) ⬇️
.../transactions/v1/blockchain_txn_poc_request_v1.erl 56.16% <0%> (-26.03%) ⬇️
...nsactions/v1/blockchain_txn_assert_location_v1.erl 67.78% <0%> (-22.82%) ⬇️
src/transactions/v1/blockchain_txn_routing_v1.erl 65.85% <0%> (-21.96%) ⬇️
...actions/v1/blockchain_txn_security_exchange_v1.erl 65% <0%> (-21.67%) ⬇️
.../transactions/v1/blockchain_txn_add_gateway_v1.erl 71.18% <0%> (-19.5%) ⬇️
src/transactions/v1/blockchain_txn_oui_v1.erl 69.49% <0%> (-19.5%) ⬇️
.../transactions/v1/blockchain_txn_create_htlc_v1.erl 66.19% <0%> (-18.31%) ⬇️
...c/transactions/v1/blockchain_txn_token_burn_v1.erl 72.13% <0%> (-16.4%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6ccad...d15a318. Read the comment docs.

@Vagabond Vagabond merged commit 43d23b6 into master Jan 9, 2020
@Vagabond Vagabond deleted the pevm/dont-validate-selfsigned-blocks branch January 9, 2020 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants