Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Move the OUI upgrade and field to master #397

Merged
merged 2 commits into from Apr 1, 2020
Merged

Conversation

evanmcc
Copy link
Contributor

@evanmcc evanmcc commented Mar 13, 2020

This also gets rid of neighbors, and should help tame some of the apparent drift we've been seeing.

NB: this is not something that we can roll back without a code change. Once it's out there, we've committed to it.

@vihu
Copy link
Member

vihu commented Mar 13, 2020

Should we add a getter for oui while here? In gateway_ledger_v2

@vihu vihu changed the title move the OUI upgrade and field to master Move the OUI upgrade and field to master Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #397 into master will decrease coverage by 6.61%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   68.53%   61.92%   -6.62%     
==========================================
  Files          72       72              
  Lines        7366     7382      +16     
==========================================
- Hits         5048     4571     -477     
- Misses       2318     2811     +493
Impacted Files Coverage Δ
src/blockchain.erl 65.71% <0%> (-1%) ⬇️
src/ledger/v1/blockchain_ledger_gateway_v2.erl 64.49% <50%> (-4.45%) ⬇️
src/poc/blockchain_poc_target_v3.erl 0% <0%> (-93.75%) ⬇️
src/poc/blockchain_poc_path_v3.erl 0% <0%> (-89.1%) ⬇️
src/poc/blockchain_poc_target_v2.erl 0% <0%> (-89.02%) ⬇️
src/poc/blockchain_poc_path_v4.erl 0% <0%> (-88.2%) ⬇️
src/poc/blockchain_poc_path_v2.erl 0% <0%> (-87.97%) ⬇️
src/blockchain_utils.erl 76% <0%> (-10.67%) ⬇️
src/blockchain_score_cache.erl 75.6% <0%> (-2.44%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f49af3...c826f01. Read the comment docs.

@evanmcc evanmcc merged commit 7f8731b into master Apr 1, 2020
@evanmcc evanmcc deleted the pevm/port-oui-to-master branch April 1, 2020 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants