This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
syuan100
commented
Oct 5, 2021
- Add configs for storing HTLC receipts
- Endpoint to fetch HTLC receipts
- Add new configs
… add storing HTLC receipts
abhay
reviewed
Oct 6, 2021
Regarding your review comments above @abhay, would we want store htlc receipts to be default true or keep it as default false? |
Agreed
…Sent from my iPhone
On Oct 6, 2021, at 07:25, Abhay Kumar ***@***.***> wrote:
@abhay commented on this pull request.
In config/docker_rosetta_testnet.config:
> @@ -22,6 +22,6 @@
{seed_node_dns, ""},
{honor_quick_sync, false},
{quick_sync_mode, assumed_valid},
- {store_implicit_burns, true}
+ {store_htlc_receipts, true}
I think default true makes sense here since hltcs are balance changing and useful for anyone who's using this chain client as a directly connected wallet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Updated |
@abhay Could we possibly get this merged for rosetta? It'll help some work I want to do over the weekend |
Yes. Let's land it and we can assume that if we need to follow up, we can. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.