Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Add HTLC endpoint #63

Merged
merged 9 commits into from Oct 9, 2021
Merged

Add HTLC endpoint #63

merged 9 commits into from Oct 9, 2021

Conversation

syuan100
Copy link
Contributor

@syuan100 syuan100 commented Oct 5, 2021

  • Add configs for storing HTLC receipts
  • Endpoint to fetch HTLC receipts

@syuan100 syuan100 marked this pull request as ready for review October 5, 2021 06:28
config/docker_rosetta_testnet.config Outdated Show resolved Hide resolved
rebar.config Outdated Show resolved Hide resolved
@syuan100
Copy link
Contributor Author

syuan100 commented Oct 6, 2021

Regarding your review comments above @abhay, would we want store htlc receipts to be default true or keep it as default false?

@madninja
Copy link
Member

madninja commented Oct 6, 2021 via email

@syuan100
Copy link
Contributor Author

syuan100 commented Oct 6, 2021

Updated

@syuan100 syuan100 requested a review from abhay October 7, 2021 04:45
@syuan100
Copy link
Contributor Author

syuan100 commented Oct 8, 2021

@abhay Could we possibly get this merged for rosetta? It'll help some work I want to do over the weekend

@abhay
Copy link
Contributor

abhay commented Oct 9, 2021

Yes. Let's land it and we can assume that if we need to follow up, we can.

@abhay abhay merged commit f565512 into helium:master Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants