Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swich to erlang-tc for threshold-cryptography #36

Merged
merged 1 commit into from
May 3, 2021
Merged

Conversation

vihu
Copy link
Member

@vihu vihu commented Apr 8, 2021

This adds support for curve BLS12-381 keys. Please refer to HIP30 for more information.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #36 (d99f4c3) into master (0260f48) will decrease coverage by 3.11%.
The diff coverage is 83.33%.

❗ Current head d99f4c3 differs from pull request most recent head 505e91a. Consider uploading reports for the commit 505e91a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   85.90%   82.78%   -3.12%     
==========================================
  Files           8        4       -4     
  Lines         532      366     -166     
==========================================
- Hits          457      303     -154     
+ Misses         75       63      -12     
Impacted Files Coverage Δ
src/dkg_util.erl 71.42% <66.66%> (-8.58%) ⬇️
src/dkg_hybridvss.erl 81.57% <81.44%> (+1.02%) ⬆️
src/dkg_hybriddkg.erl 84.45% <85.71%> (+4.64%) ⬆️
src/dkg_commitment.erl 82.22% <95.65%> (-4.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e73a6...505e91a. Read the comment docs.

Copy link
Contributor

@evanmcc evanmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that I'm a bit too far from the TC code for you to merge this on my approval, but this looks reasonable to me.

@evanmcc evanmcc marked this pull request as ready for review April 26, 2021 23:34
@Vagabond Vagabond merged commit a22b841 into master May 3, 2021
@Vagabond Vagabond deleted the adt/erlang-tc branch May 3, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants