Start hbbft on demand #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a test for the same * add max buffer size to the hbbft data record
Vagabond
reviewed
Jun 29, 2018
src/hbbft.erl
Outdated
| @@ -22,6 +23,7 @@ | |||
| j :: non_neg_integer(), | |||
| round = 0 :: non_neg_integer(), | |||
| buf = [] :: [binary()], | |||
| max_buf = infinity :: infinity, | |||
There was a problem hiding this comment.
We need a way to set this, right?
There was a problem hiding this comment.
right, will add to init for the time being.
Pull Request Test Coverage Report for Build 188
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to start hbbft even with a limited number of transactions so we can have shorter blocks.
Includes: