Attempt to ensure messages are output in the correct order #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 196
💛 - Coveralls |
vihu
reviewed
Jul 10, 2018
src/hbbft_bba.erl
Outdated
| @@ -192,7 +192,7 @@ bval(Data=#bba_data{n=N, f=F}, Id, V) -> | |||
| %% TODO need more entropy for the SID | |||
| %% We have enough AUX and CON messages to reveal our share of the coin | |||
There was a problem hiding this comment.
While we're on it could you fix the CON typo to CONF as well please.
vihu
reviewed
Jul 10, 2018
| @@ -177,7 +177,7 @@ bval(Data=#bba_data{n=N, f=F}, Id, V) -> | |||
| true -> | |||
| %% XXX How many times do we send AUX per round? I think just once | |||
| Random = rand_val(NewData2#bba_data.bin_values), | |||
| {NewData2#bba_data{aux_sent = true}, [{multicast, {aux, NewData2#bba_data.round, Random}} | ToSend]}; | |||
| {NewData2#bba_data{aux_sent = true}, ToSend ++ [{multicast, {aux, NewData2#bba_data.round, Random}}]}; | |||
There was a problem hiding this comment.
Adding this here for posterity. The messages from the current round should be processed once the previous rounds are done. We were incorrectly appending the message at the head of the list, this ideally fixes it.
vihu
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.