Add a event stamp function for attaching causality information to RBC #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To provide some semblence of causality we allow the user of hbbft to provide a 'stamp fun' that allows them to attach some causality information to the Reliable Broadcast payload. This can be a timestamp, a monotonic counter, a vector clock, whatever. The resulting 'stamp' is encrypted along with the other transactions and is thus subject to the consensus rules around agreeing on transactions.
Pull Request Test Coverage Report for Build 253
💛 - Coveralls |
vihu
reviewed
Sep 21, 2018
src/hbbft.erl
Outdated
| thingtosign :: undefined | erlang_pbc:element() | ||
| thingtosign :: undefined | erlang_pbc:element(), | ||
| stampfun :: undefined | {atom(), atom(), list()}, | ||
| stamps = [] :: list() |
There was a problem hiding this comment.
Possible to make the type tighter here?
vihu
requested changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide some semblence of causality we allow the user of hbbft to
provide a 'stamp fun' that allows them to attach some causality
information to the Reliable Broadcast payload. This can be a timestamp,
a monotonic counter, a vector clock, whatever. The resulting 'stamp' is
encrypted along with the other transactions and is thus subject to the
consensus rules around agreeing on transactions.