Add some better status output #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vagabond
force-pushed
the
adt/better-stats
branch
from
b95482c
to
af30472
Compare
vihu
reviewed
Sep 22, 2018
| @@ -443,3 +445,11 @@ serialize_hbbft_data(#hbbft_data{batch_size=BatchSize, | |||
| -spec is_serialized(hbbft_data() | hbbft_serialized_data()) -> boolean(). | |||
| is_serialized(Data) when is_record(Data, hbbft_serialized_data) -> true; | |||
| is_serialized(Data) when is_record(Data, hbbft_data) -> false. | |||
|
|
|||
| group_by(Tuples) -> | |||
There was a problem hiding this comment.
Nitpicking here, move this to hbfft_utils perhaps?
There was a problem hiding this comment.
I'm hesitant to put functions with a single callsite in a utility module. If we need it elsewhere we should move it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.