Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consensus fixes to ACS #30

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Conversation

Vagabond
Copy link
Member

This PR adds another completion check for ACS and it ensures we track we provided an input to a BBA even if that BBA was already completed.

In testing conditions it seems to resolve the intermittent consensus failure we've been tracking.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 312

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.3%) to 82.183%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hbbft_acs.erl 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
src/hbbft_acs.erl 1 86.42%
src/hbbft_cc.erl 2 65.52%
src/hbbft_bba.erl 3 83.11%
Totals Coverage Status
Change from base Build 309: -1.3%
Covered Lines: 369
Relevant Lines: 449

💛 - Coveralls

Copy link
Contributor

@evanmcc evanmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@vihu vihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright 👍

@Vagabond Vagabond merged commit d7ebbc1 into master Nov 19, 2018
@Vagabond Vagabond deleted the adt/one-more-acs-completion-check branch November 19, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants