Performance improvements for decoding ACS results #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces 2 performance optimizations: * Tag each share with its validity status (true, false or undefined) * Only try to decrypt if we haven't already decrypted that result
Pull Request Test Coverage Report for Build 360
💛 - Coveralls |
vihu
approved these changes
Jan 16, 2019
src/hbbft.erl
Outdated
| %% check if we have enough to decode the bundle | ||
| SharesForThisBundle = [ S || {{Idx, _}, S} <- maps:to_list(NewShares), I == Idx], | ||
| case length(SharesForThisBundle) > Data#hbbft_data.f andalso not maps:is_key({I, J}, Data#hbbft_data.dec_shares) andalso lists:keymember(I, 1, Data#hbbft_data.acs_results) of | ||
| case maps:is_key({I, J}, Data#hbbft_data.dec_shares) orelse maps:is_key(I, Data#hbbft_data.decrypted) of |
There was a problem hiding this comment.
I'm just wondering if it would be better to separate these out or change the order of conditions to fail faster? If you already have decrypted no need to check dec_shares presumably?
evanmcc
reviewed
Jan 16, 2019
|
Refactored some of the conditionals (some of them were redundant) and removed stale comment. |
evanmcc
approved these changes
Jan 16, 2019
|
It's extremely possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces 2 performance optimizations: