Session key for packet_router #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ke6jjj
suggested changes
Jul 30, 2023
madninja
force-pushed
the
madninja/session_key
branch
2 times, most recently
from
70f211b
to
a233c0c
Compare
madninja
force-pushed
the
madninja/session_key
branch
from
1bc1e6b
to
120dc1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: On a connect all pending uplink packets are sent but only after the session key is established to avoid a large rush of signatures before the session key ie active. Two other alternatives are to (1) add a delay before sending queued packets with whatever key is available (gateway or session) or (2) send all waiting packets and then deal with session key initialization when it arrives after that