Fix 0 Amount Transfers #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenan
approved these changes
Dec 8, 2020
|
This was pretty interesting to debug. I would think that the js proto serializer should omit fields when value is default but that doesn't seem the case. Unsure if its a misconfiguration, a bug in the js proto serializer, or whether its "just the way it is" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the amount is 0 and we pass it into the proto for serialization the default value is actually getting serialized into the proto (which is not expected) and on the blockchain it doesnt get serialized in for default values which is what is supposed to happen.
For this reason transfers with 0 amount were failing. When we dont include these 0 values proto uses the default 0 and doesnt include them in the serialized transaction which makes everything line up correctly.