Feature/chart data #201
Merged
Feature/chart data #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewcarlreetz
approved these changes
Feb 17, 2021
|
|
||
| const changeTimeframe = (t: number) => { | ||
| setTimeframe(t) | ||
| const changeTimeframe = useCallback((range: ChartRange) => { |
There was a problem hiding this comment.
you could curry this function so you don't have to have inline functions
const changeTimeframe = useCallback(
(range: ChartRange) => () => {
setTimeframe(range)
triggerImpact()
},
[],
)
Then just call it right away...
<TouchableWithoutFeedback onPress={changeTimeframe('daily')}>
| @@ -66,60 +85,47 @@ const WalletChart = ({ height }: Props) => { | |||
| > | |||
| <CarotRight width={12} height={12} style={{ marginRight: 4 }} /> | |||
There was a problem hiding this comment.
Would be a good idea to get rid of some of the inline styling
<Box flexDirection="row" alignItems="center">
<CarotRight width={12} height={12} />
<Text variant="body2" marginLeft="s">
{round(focusedData?.down, 2).toLocaleString()}
</Text>
</Box
| justifyContent="center" | ||
| position="absolute" | ||
| > | ||
| <ActivityIndicator /> |
There was a problem hiding this comment.
ActivityIndicator needs a color prop in order to show on Android
|
|
||
| const handleFocusData = (data: ChartData | null): void => { | ||
| setFocusedData(data) | ||
| const handleFocusData = (chartData: ChartData | null): void => { |
There was a problem hiding this comment.
Could useCallback here
| id: [2, i].join('-'), | ||
| })), | ||
| } | ||
|
|
||
| export default WalletChart |
There was a problem hiding this comment.
might want to memoize this?
src/utils/walletClient.ts
Outdated
| @@ -12,6 +13,7 @@ const makeRequest = async (url: string, opts: RequestInit) => { | |||
| } | |||
|
|
|||
| const route = [Config.WALLET_API_BASE_URL, url].join('/') | |||
| // const route = ['http://localhost:4000/api', url].join('/') | |||
damn ok I'll tilt at the alignment windmill some more. mine are the reverse, with the blue bars being the largest and the green dots at the top. |
* main: add japanese (#196) Feature/notifications UI updates (#197) Remove animation pandemonium (#198) Handle hotspot not yet being added to the chain. (#204) qr scan copy, learn link copy, externlize for translation (#199) Hotspot Checklist (#194) Bugfix/hotspot onboarding (#192) Feature/activity loading ux (#186)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #88
depends on wallet api PR: https://github.com/helium/wallet-api/pull/13