Hotspot page design tweaks #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewcarlreetz
approved these changes
Feb 18, 2021
| downColor={grayLight} | ||
| labelColor={black} | ||
| /> | ||
| <Text variant="body3" color="black" paddingTop="xs"> | ||
| {/* TODO removing this for now to fit the design better */} | ||
| {/* <Text variant="body3" color="black" paddingTop="xs"> | ||
| {focusedData ? focusedData.day : ' '} |
There was a problem hiding this comment.
Can we put it somewhere else? It is nice to see the day
There was a problem hiding this comment.
I'll make a design ticket for it. having that gap there at the bottom was definitely throwing the alignment off though
tyler-whitman
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #121
I broke out this out to a separate issue because it's nontrivial: #224
Showing other hotspots on the map is also already its own issue