Multisig support #10
Merged
Multisig support #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 97.38% 94.94% -2.45%
==========================================
Files 1 1
Lines 153 356 +203
==========================================
+ Hits 149 338 +189
- Misses 4 18 +14
Continue to review full report at Codecov.
|
xandkar
force-pushed
the
xandkar/multisig
branch
4 times, most recently
from
674b233
to
7b134a4
Compare
Vagabond
reviewed
Apr 6, 2021
Vagabond
reviewed
Apr 6, 2021
Vagabond
reviewed
Apr 6, 2021
xandkar
force-pushed
the
xandkar/multisig
branch
4 times, most recently
from
c3e2d66
to
23de3c5
Compare
vihu
reviewed
Apr 7, 2021
vihu
reviewed
Apr 7, 2021
xandkar
force-pushed
the
xandkar/multisig
branch
15 times, most recently
from
9f8cfa4
to
043da5b
Compare
Vagabond
reviewed
Apr 15, 2021
xandkar
force-pushed
the
xandkar/multisig
branch
from
ee33afd
to
1f84191
Compare
vihu
reviewed
Apr 16, 2021
vihu
reviewed
Apr 16, 2021
xandkar
force-pushed
the
xandkar/multisig
branch
2 times, most recently
from
6627b4d
to
1132f0c
Compare
xandkar
force-pushed
the
xandkar/multisig
branch
from
1132f0c
to
dcf5a96
Compare
Add multisig_eqc
sha3_256 and blake2b256
Update eqc for API changes
|
I think the last thing here is to add deterministic sorting of the keys, as discussed on the call yesterday to help reduce the scope for hash collisions. |
xandkar
force-pushed
the
xandkar/multisig
branch
from
6ef58d0
to
ce980fe
Compare
madninja
reviewed
May 3, 2021
instead of the hard-coded one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.