Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Disable fetching latest snapshot on validators #1248

Merged
merged 1 commit into from Nov 30, 2021
Merged

Disable fetching latest snapshot on validators #1248

merged 1 commit into from Nov 30, 2021

Conversation

PaulVMo
Copy link
Contributor

@PaulVMo PaulVMo commented Nov 22, 2021

Disable the latest snapshot functionality for syncing validators and instead use only the latest blessed snapshot. Fetching the latest snapshot from a URL creates a security and reliability risk:

  1. the hosting URL of the latest snapshot is another attack vector on validators since validators do not have a way to verify the hash of the snapshot
  2. not all of the latest snapshots work - as identified in Discord, some of the snapshots cause syncing issues. unlike blessed snapshots, no one reviews or tests the latest snapshots

@Vagabond
Copy link
Member

This looks reasonable @evanmcc can you check?

@evanmcc evanmcc merged commit 26ba5c8 into helium:master Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanmcc evanmcc evanmcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PaulVMo @Vagabond @evanmcc