This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Fix dialyzer warning: 6th item in request tuple is binary, not function. #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a dialyzer warning cause by mistakenly stating that the sixth element of the tuple that is cached for a target request is a function(). It is not; it's a binary() containing the challenger's signature.
|
In case you are confused why dialyzer didn't like the old type spec, the "inferred" type came from here: miner/src/poc/miner_poc_grpc_client_statem.erl Line 1023 in 5027821 The old type specified that the argument being passed as " |
This comment was marked as abuse.
This comment was marked as abuse.
evanmcc
approved these changes
Jun 3, 2022
jeffgrunewald
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a dialyzer warning cause by mistakenly stating that the sixth
element of the tuple that is cached for a target request is a function().
It is not; it's a binary() containing the challenger's signature.