This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Let relcast do term serialization, if needed #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsugiyama
reviewed
Jul 7, 2022
marcsugiyama
reviewed
Jul 7, 2022
marcsugiyama
reviewed
Jul 7, 2022
| @@ -463,7 +462,7 @@ deserialize(#{sk := SKSer, | |||
| case StateMap of | |||
| #{K := V} when V /= undefined andalso | |||
| V /= Bundef -> | |||
| binary_to_term(V); | |||
| V; | |||
| _ when K == sig_phase -> | |||
| sig; | |||
| _ when K == seen -> | |||
There was a problem hiding this comment.
Since we're ignoring these fields in deserialize do we need to serialize them in the first place? Skipping these fields in serialize will reduce the number of field-by-field compares in relcast.
There was a problem hiding this comment.
I think its populating the default values if they're not defined.
There was a problem hiding this comment.
OK, I get it now. The first case clause checks for undefined and falls through to the others if it is.
marcsugiyama
approved these changes
Jul 8, 2022
evanmcc
force-pushed
the
adt/relcast-serializing
branch
from
73f9363
to
bc093e0
Compare
evanmcc
approved these changes
Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to helium/relcast#50