This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
add test for multikeys #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanmcc
force-pushed
the
pevm/multisig
branch
from
7a3ae58
to
a0a7dfc
Compare
Vagabond
reviewed
Oct 7, 2020
evanmcc
force-pushed
the
pevm/multisig
branch
from
a0a7dfc
to
5455c2f
Compare
evanmcc
force-pushed
the
pevm/multisig
branch
from
55c54e5
to
06ca4c7
Compare
Vagabond
reviewed
Oct 14, 2020
test/miner_blockchain_SUITE.erl
Outdated
| BinPub4 = libp2p_crypto:pubkey_to_bin(Pub4), | ||
| BinPub5 = libp2p_crypto:pubkey_to_bin(Pub5), | ||
|
|
||
| Txn6 = vars(#{?use_multi_keys => true}, 2, Priv), |
There was a problem hiding this comment.
Why are these being done in discrete var updates?
There was a problem hiding this comment.
to make sure that that transition works safely, just in case it happens. it's done the other way, as an atomic update, in the election test.
There was a problem hiding this comment.
oops, that's not true, will change this one.
Vagabond
reviewed
Oct 14, 2020
| Txn7 = blockchain_txn_vars_v1:proof(Txn7_1, Proof7), | ||
| _ = [ok = ct_rpc:call(M, blockchain_worker, submit_txn, [Txn7]) || M <- Miners], | ||
|
|
||
| ct:pal("transitioned to multikey"), |
There was a problem hiding this comment.
Should we use wait_for_chain_var_update here too?
|
Vagabond
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for helium/blockchain-core#526