This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
rework config changes #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihu
reviewed
Jun 6, 2019
|
May wanna rebase this and do a local run.sh? |
evanmcc
force-pushed
the
pevm/local-chain-config
branch
from
e04f0b9
to
a8e0b48
Compare
madninja
approved these changes
Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
despite the commit message in 9e57b33, mem mode was pulled.
this PR changes how configuration is done for sys.config, moving to more recent rebar3 features, rather than using raw relx templating.
after this merges, sys.config should be pulled from nextgate, and the one in miner should be allowed to hit the hotspot unchanged. all changes for local development should be done in
config/dev.config, which can be accessed either by using./run.shfor a local cluster, ormake devreleasefor a local release.