Allow setting indent globally

[scgtrp]

I currently have an incredibly long ~/.config/helix/languages.toml, to which I append a copy of this for every language I use or encounter:

[[language]]
name = "..."
indent = { tab-width = 4, unit = "\t" }
auto-pairs = false

I discovered while writing this that I don't actually have to set auto-pairs = false in each language anymore (I don't think the global one existed/worked when I started using Helix?), so that's neat, thanks!

I would like to be able to do the same for indent. The desired behavior is that I can say "always indent with tabs, for any file type", and spaces are only used if I open an existing file that is already indented with spaces.

Potential issue with this: Some languages (e.g. makefiles) require a particular type of indentation as part of their syntax. These languages should probably have some sort of "no, really, use this even if the user said something else" flag in their indent configuration, to avoid emitting broken makefiles when the user has set space-indentation globally. Alternatively, the language-level indent could be split into indent and default-indent, where the order of precedence is language.indent > global.indent > language.default-indent.

[sploders101]

I would like to second this. I'm currently doing the exact same thing, and am still worried I run the risk of starting to use a new language that automatically starts using spaces for indentation without me noticing.

Not trying to get into the tabs vs spaces debate (just adding my objective reasoning for this need), but my personal opinion is that someone's personal indentation width preference should not be forced on everyone else. I have a lot of trouble reading 2-space indentation, so I like to render at 4, and tabs let me do that, so as a courtesy to others, I use tabs so they can view my code however they like. However, in today's development world, devs (or at least I) use so many languages on a day-to-day basis it's hard to keep track, and I'd love a global setting with language-specific override for languages with intolerant syntax (for example, Home Assistant's YAML parser really seems to hate tabs, so I should be able to override for YAML).

I may be willing to help with this in my spare time if someone could point me to the relevant parts of the project.

[pbrkr]

I think this is a key feature for users working on projects which have a strict coding style and use multiple programming languages.

Also note that simply enumerating indent overrides for all languages which helix currently knows about is not a one-off solution. This list would also have to be updated if new languages are added to Helix's default languages.toml file.

[dead10ck]

I'm actually personally against having a global setting for tab width. Each language has its own style, and I don't agree with the mindset of just ignoring idiomatic conventions. Just as one shouldn't write snake case in Java, or camel case in Rust, one shouldn't use an unconventional tab width.

Also, it's likely that if you really insisted on doing this, you're probably not talking about more than half a dozen languages, max. It's not like you'd notice some Prolog dialect was added and have to go add another entry.

[scgtrp]

I don't actually use Helix anymore (and will probably unsubscribe from this ticket), but as of when I stopped, I had 11: C++, C, Rust, JavaScript, TypeScript, HTML, YAML, Python, CSS, Markdown, and Bash. For the sort of personal use I was using it for, consistency with my own opinions was far more important than consistency with the opinions of some style guide.

The nice thing about optional settings is that you don't have to set them if they don't suit you :)

[linkert]

I understand that I'm not the target audience as I'm pretty much a normie who enjoys tinkering with my computer, a non-dev, mostly janky scripts, configs and markdown documents. But I would also like some way of telling Helix: unless told otherwise a tab consists of spaces, two spaces to be exact.

[lucyColeclough]

I'm actually personally against having a global setting for tab width. Each language has its own style, and I don't agree with the mindset of just ignoring idiomatic conventions. Just as one shouldn't write snake case in Java, or camel case in Rust, one shouldn't use an unconventional tab width.

Also, it's likely that if you really insisted on doing this, you're probably not talking about more than half a dozen languages, max. It's not like you'd notice some Prolog dialect was added and have to go add another entry.

My issue is that I don't want to write a config for every language.
If you're one who enjoys spaces then it wouldnt be as obvious of a problem.

[lucyColeclough]

in regards to #6652
I propose the notion that a global indent option would override any default configuration in helix
Then any option specified in the user~s languages.toml would then override this global option
This prevents the need to specify something like indent.required= true for each language, as it is assumed that if a user specifies a language in languages.toml, that it should override the global default
Perhaps behaviour for whether non specified fields should inherit from the global setting or the helix default
This could be a per language setting, either inherit from global or helix defaults, that way it would work with languages with no custom fields in languages.toml

If going with that, then to increase reuse whilst resolving the issue posed in the openning comment of this thread, perhaps languages which are dependent on a specific indentation can have their inheritance set to the helix default, by default as opposed to the user specified global setting.

I do not have the time to change this my self and it is not an issue that would be desirable for me to see develop into a halt in existing work.

[Lilith-In-Starlight]

i think global options should override the default languages.toml and the global languages.toml, meaning they are only overriddeo by the languages.toml present in a project directory

This means that you can have

• Your customized global default
• Your customized edge cases for certain languages
• Your customized edge cases for certain projects

Which I think is an ideal amount of control

[Rudxain]

@dead10ck

Each language has its own style, and I don't agree with the mindset of just ignoring idiomatic conventions.

That's why formatters and linters are a thing 🙃. And that's why the global setting should be just a default, overriden by whatever indent.unit is detected in a file or languages.toml.

Just as one shouldn't write snake case in Java, or camel case in Rust, one shouldn't use an unconventional tab width.

rustc & clippy warn when using non-idiomatic naming-conventions. I would expect other linters (maybe even "intrusive" formatters) would go as far as to rename all symbols on "auto-fix"

[getawaywithrmdir]

I'm dying for a global indentation option.

I was even trying to figure out how to automatically run the ":indent-style" command every time I open a buffer for a clunky band-aid.

[kirawi]

I don't think we're planning to do this since we want the plugin system to handle this kind of stuff. But if you're not opposed to compiling from source, you would just replace the self.indent_style block in

helix/helix-view/src/document.rs

Lines 1015 to 1024 in 41dec92

	pub fn detect_indent_and_line_ending(&mut self) {
	self.indent_style = auto_detect_indent_style(&self.text).unwrap_or_else(|| {
	self.language_config()
	.and_then(|config| config.indent.as_ref())
	.map_or(DEFAULT_INDENT, |config| IndentStyle::from_str(&config.unit))
	});
	if let Some(line_ending) = auto_detect_line_ending(&self.text) {
	self.line_ending = line_ending;
	}
	}

with

self.indent_style = IndentStyle::Tabs;
// Or
self.indent_style = IndentStyle::Spaces(n)

But don't remove the if let Some ... stuff

[Rudxain]

compiling from source

About that, if anyone here runs hx frequently and/or for long-periods, I recommend target-cpu=native. I haven't tried it (yet), so I can't say if compile-times change considerably

[odurc]

Alternatively, to the original proposal, I'd suggest creating a configuration to set a default indent and unit only for newly created buffers, i.e. just after I hit :n + enter. The new buffer has no language associated with it yet and therefore it should simply use my default definition of indent and unit regardless of the language I'm writing. After I write the buffer (:w), hence naming the language via the file extension, Helix should continue to use whatever indent configuration it has started with regardless of the language which is the case already with "indent detection".