New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant panic on opening any .go file #1746
Labels
Comments
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this issue
Mar 4, 2022
closes helix-editor#1746 The queries for Go were updated in ddbf036. The old ref was before this commit, so running helix from the flake nix flake run github:helix-editor/helix/d62ad8b595a4f901b9c5dba1bb6e8f70ece395bf -- path/to/file.go will crash because the old grammar's query analysis will fail (because `iota` was not yet a named node). This commit updates the version of the grammars that we pull down when building the flake so that the queries match the grammars. We'll have to do an update like this whenever a grammar is bumped in a breaking way (which happens fairly often in tree-sitter) until helix-editor#1659 comes along and the version of the grammar becomes tied to the version declared in source.
archseer
pushed a commit
that referenced
this issue
Mar 5, 2022
closes #1746 The queries for Go were updated in ddbf036. The old ref was before this commit, so running helix from the flake nix flake run github:helix-editor/helix/d62ad8b595a4f901b9c5dba1bb6e8f70ece395bf -- path/to/file.go will crash because the old grammar's query analysis will fail (because `iota` was not yet a named node). This commit updates the version of the grammars that we pull down when building the flake so that the queries match the grammars. We'll have to do an update like this whenever a grammar is bumped in a breaking way (which happens fairly often in tree-sitter) until #1659 comes along and the version of the grammar becomes tied to the version declared in source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bisect suggests ddbf036 may be the culprit.
git revert
ing it over master fixes the crash, but I assume there's a better way to solve this than reverting an update.Reproduction steps
Environment
~/.cache/helix/helix.log
N/AThe text was updated successfully, but these errors were encountered: