Cannot edit a file if the file is named justfile

[drzymalanet]

Summary

My edits to the justfile are overwritten. If I change the name, it works. If i create a brand new file named justfile with helix, I can put the file contents into the file, but after reopening and saving, file changes are not saved.

Reproduction Steps

I tried this:

mkdir -p /tmp/test
cd /tmp/test
hx justfile
# Create file contents, then `:wq`
hx justfile
# Change anything and then `:wq`
cat justfile
# Observe that the file did not change.

Repeat the same with a differently named file and it will work. It seems to me that the justfile syntax highlighter is causing the problem but I don't know.

Helix log

When creating the file named justfile:

2024-02-23T00:46:11.334 helix_view::document [ERROR] Formatter error: error: Unknown start of token:
 ——▶ justfile:1:8
  │
1 │ bbbbbbb;
  │        ^

The bbbbb is not what I was adding to the file. It seems that the formatter is in a different dimension.

Platform

Linux

Terminal Emulator

GNOME Terminal 3.28.3

Installation Method

nixpkgs

Helix Version

helix 23.10

[the-mikedavis]

This would be caused by the external formatter rather than the tree-sitter parser:

helix/languages.toml

Line 2833 in 98ebeee

formatter = { command = "just", args = ["--dump"] }

I can't reproduce this but we should remove that line anyways: just --dump doesn't format stdin, it reads justfile. External formatters should take input from stdin and print the formatted output to stdout

[drzymalanet]

@the-mikedavis I have copied the languages.toml file you've mentioned into my helix config dir:

• Removing that line did not help
• Setting auto-format = false did fix the issue.

[kirawi]

The configs are merged, so you'd have to unset it to "" rather than delete it.

[drzymalanet]

@kirawi Yes I figured that out.

@the-mikedavis @kirawi Can we revert commit 0eec518 ?

[the-mikedavis]

Yep please send a PR

[drzymalanet]

@the-mikedavis @kirawi @rokf @kpbaks @archseer @rokf
Hello, #9778 is ready.