Add jump-label to Kanagawa theme + format #10030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
reviewed
Mar 28, 2024
runtime/themes/kanagawa.toml
Outdated
| "ui.virtual.inlay-hint.parameter" = { fg = "carpYellow", modifiers = ["dim"] } | ||
| "ui.virtual.inlay-hint.type" = { fg = "waveAqua2", modifiers = ["dim"] } | ||
| "ui.virtual.inlay-hint.type" = { fg = "waveAqua2", modifiers = ["dim"] } | ||
| "ui.virtual.jump-label" = { fg = "peachRed", bg = "sumiInk0", modifiers = ["bold"] } |
There was a problem hiding this comment.
I wouldn't set a background color. Setting background colors for text can mess with some ui components like cursorline. I don't believe other themes set the background color for jump labels
There was a problem hiding this comment.
Thanks for your suggestion @pascalkuthe. I wasn't sure about the background either.
The official theme does use one, but it also change the background of the whole background...
I agree, changing the background of the jump-label without changing the whole background is irrelevant.
I pushed a new commit to remove it
|
@the-mikedavis Just removed the values alignment from the file ! |
the-mikedavis
approved these changes
Mar 28, 2024
the-mikedavis
added
A-theme
pascalkuthe
approved these changes
Mar 28, 2024
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
* Add jump-label to Kanagawa theme + format * Remove bg color for jump-label * Remove values alignment
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Apr 3, 2024
* Add jump-label to Kanagawa theme + format * Remove bg color for jump-label * Remove values alignment
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Add jump-label to Kanagawa theme + format * Remove bg color for jump-label * Remove values alignment
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Add jump-label to Kanagawa theme + format * Remove bg color for jump-label * Remove values alignment
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Add jump-label to Kanagawa theme + format * Remove bg color for jump-label * Remove values alignment
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
* Add jump-label to Kanagawa theme + format * Remove bg color for jump-label * Remove values alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
ui.virtual.jump-labelto the Kanagawa theme and made some formatting.Please let me know if I overstepped while formatting the file.
I got the colors from the official Kanagawa repository