Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lsp rename symbol . #1011

Merged
merged 1 commit into from Nov 8, 2021
Merged

add lsp rename symbol . #1011

merged 1 commit into from Nov 8, 2021

Conversation

cossonleo
Copy link
Contributor

@cossonleo cossonleo commented Nov 8, 2021 •
edited

add lsp rename_symbol
improve apply_workspace_edit

I really need this feature so I can't wait for #689 to merged.
And the PR is baseed on #689 and https://github.com/kak-lsp/kak-lsp/blob/4f24f0f1cb3689d86d68e0463ab0f191a8166ba1/src/workspace.rs#L138-L241.

The lsp rename_symbol protocol feature copy from #689.

The apply_document_resource_op function copy from https://github.com/kak-lsp/kak-lsp/blob/4f24f0f1cb3689d86d68e0463ab0f191a8166ba1/src/workspace.rs#L138-L241.

@sudormrfbin
Copy link
Member

I don't think we should change gr from goto reference since every other command under g is some kind of goto command.

@cossonleo
add lsp rename symbol shortcut is space-r
2a526df 
improve apply_workspace_edit
@cossonleo
Copy link
Contributor Author

I don't think we should change gr from goto reference since every other command under g is some kind of goto command.

I have restore goto_reference shortcut and use space-r for rename_symbol

@archseer archseer linked an issue Nov 8, 2021 that may be closed by this pull request
rename a function #1003
Closed
archseer
archseer approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@archseer archseer merged commit 29e6849 into helix-editor:master Nov 8, 2021
@sudormrfbin
Copy link
Member

Seems like the book wasn't updated with the new space+r keybind. Great job btw @cossonleo 🎉

@cossonleo cossonleo deleted the lsp_rename branch November 9, 2021 01:58
@archseer archseer mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename a function
3 participants
@cossonleo @sudormrfbin @archseer