Add option to not overtype on closing pairs #10301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
the
S-waiting-on-review
kirawi
reviewed
Apr 14, 2024
kirawi
reviewed
Apr 14, 2024
helix-view/src/editor.rs
Outdated
| @@ -913,6 +915,7 @@ impl Default for Config { | |||
| popup_border: PopupBorderConfig::None, | |||
| indent_heuristic: IndentationHeuristic::default(), | |||
| jump_label_alphabet: ('a'..='z').collect(), | |||
| auto_closing_overtype: false, | |||
There was a problem hiding this comment.
I'd prefer to rename it to overtype but I don't know how the maintainers feel about this
There was a problem hiding this comment.
Or it might be better to refactor AutoPairConfig into a struct (moving the current enum into a new one) and putting overtype under it. This would be a breaking change though.
There was a problem hiding this comment.
I made a new commit with the suggested changes. Instead of implimenting the From trait like original did, it felt more appropriate to add a get_pairs function that returns the enum value instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to #9595
Vscode uses three modes(always, auto - only skip over auto generated closing pairs, and never) for autoCloseOvertype, while my implementation only uses two(always and never).