readline style insert mode

[QiBaobin]

Add readline style maps into insert mode

[archseer]

You probably want to use delete_selection_impl for these:

helix/helix-term/src/commands.rs

Lines 1547 to 1573 in 9e45827

	fn delete_selection_impl(reg: &mut Register, doc: &mut Document, view_id: ViewId) {
	let text = doc.text().slice(..);
	let selection = doc.selection(view_id);
	// first yank the selection
	let values: Vec<String> = selection.fragments(text).map(Cow::into_owned).collect();
	reg.write(values);
	// then delete
	let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
	(range.from(), range.to(), None)
	});
	doc.apply(&transaction, view_id);
	}
	fn delete_selection(cx: &mut Context) {
	let reg_name = cx.register.unwrap_or('"');
	let (view, doc) = current!(cx.editor);
	let registers = &mut cx.editor.registers;
	let reg = registers.get_mut(reg_name);
	delete_selection_impl(reg, doc, view.id);
	doc.append_changes_to_history(view.id);
	// exit select mode, if currently in select mode
	exit_select_mode(cx);
	}

delete_selection will also store all the changes into history, but in insert mode we don't want to do that until insert mode is exited.

[QiBaobin]

Is it OK if I add a flag in delete_selection as it contains some common logic? Or it's better that I wrote a wrapper like current delete_selection?

fn delete_selection(cx: &mut Context) {
    delete_selection_and_append_history(cx, true);
}

fn delete_selection_and_append_history(cx: &mut Context, append_change_to_history: bool) {
    let reg_name = cx.register.unwrap_or('"');
    let (view, doc) = current!(cx.editor);
    let registers = &mut cx.editor.registers;
    let reg = registers.get_mut(reg_name);
    delete_selection_impl(reg, doc, view.id);

    if append_change_to_history {
        doc.append_changes_to_history(view.id);
    }

    // exit select mode, if currently in select mode
    exit_select_mode(cx);
}

[archseer]

We don't want the extra register logic though:

If I have: hello [world] and I press c, we get hello | with " set to world. Now if you use kill_to_line_start that would change the register. But we want to keep world.

[archseer]

So using only delete_selection_impl should be enough

[QiBaobin]

Done, thanks for the finding, please take another look.

[archseer]

Please just use delete_selection_impl. In insert mode we don't want to do any logic related to exiting select mode.

[QiBaobin]

The delete_selection_impl would yank the text to a register, is there a _ register for this? And I think we need create a selection to use delete_selection_impl too, does it mean that we already touch selection data?

fn delete_selection_impl(reg: &mut Register, doc: &mut Document, view_id: ViewId) {
    let text = doc.text().slice(..);
    let selection = doc.selection(view_id);

    // first yank the selection
    let values: Vec<String> = selection.fragments(text).map(Cow::into_owned).collect();
    reg.write(values);

    // then delete
    let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
        (range.from(), range.to(), None)
    });
    doc.apply(&transaction, view_id);
}

[archseer]

Hmm, maybe use

    let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
        (range.from(), range.to(), None)
    });
    doc.apply(&transaction, view_id);

directly in your implementations then?

[QiBaobin]

It's still need to make a selection to pass in change_by_selection, right? So I just need remove the exit_select_mode(cx);?

[archseer]

Yeah you still need to build a selection, but rather than use set_selection you can just use it directly:

Suggested change

	let selection = doc
	.selection(view.id)
	.clone()
	.transform(|range| movement::move_next_word_start(text, range, count));
	doc.set_selection(view.id, selection);
	delete_selection_insert_mode(cx)
	let selection = doc
	.selection(view.id)
	.clone()
	.transform(|range| movement::move_next_word_start(text, range, count));
	// then delete
	let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
	(range.from(), range.to(), None)
	});
	doc.apply(&transaction, view_id);

You can just inline the delete_selection_insert_mode code.

[QiBaobin]

Thanks for the suggestions, updated the code.

[archseer]

I would just inline this function everywhere, but if you want to avoid that then maybe use delete_selection_insert_mode(doc: &mut Document, view: &View, selection: &Selection), that way we avoid looking up current! again.

[QiBaobin]

Good point, updated accordingly.