Add trim_selections command

[ath3]

No description provided.

[archseer]

I think using regex is overkill. You should be able to fetch the range.fragment() then use skip_while ch.is_whitespace(): https://github.com/helix-editor/helix/blob/master/helix-core/src/movement.rs#L150-L181

[ath3]

thats what i originally did, then changed to regex cause of the ending whitespaces, good thing i made backup

[ath3]

Nevermind, i didnt know about the backward search, seems like trim_selections will be the first one to use it 🕺

[ath3]

For some reason backwards_skip_while is starting from pos+1, is there a reason for that or should i change it?

[archseer]

I think that was so that the current pos is included once you reverse the direction. chars().rev() would skip pos and instead start with pos-1

[archseer]

Though maybe that's not the case and you can remove that. I see other code simply reversing https://github.com/helix-editor/helix/blob/b824e091a948c076a428fb981cd5be2929378533/helix-core/src/textobject.rs#L19-21

[archseer]

This happens only when the whole range is whitespace right? Those ranges should be removed altogether, you can use ranges = filter_map+collect instead of transform to construct a new selection. (You'll need to check !ranges.is_empty?() and fail because a selection needs at least one range)

[archseer]

Rather than this check for > 0 then -1 I think you have to use prev_grapheme_boundary

[archseer]

If backwards_skip_while returns none then you also end up increasing end by 1 here (end = end+1)

[archseer]

Actually, I think you want to use range.cursor

helix/helix-core/src/selection.rs

Line 264 in b824e09

pub fn cursor(self, text: RopeSlice) -> usize {

This way you have an inclusive range between range.anchor and range.cursor()(you have to check which one is start and which one is end based on orientation though)

[pickfire]

What is the use case for this?

[EpocSquadron]

@pickfire this is a feature kakoune includes. One use case is when you have a selection spanning many lines of code at different indentation levels. You use split on newlines A-s to get a selection for each line of code, then want to do something with those lines that won't work if the leading whitespace is present. So trim selections _ let's you get just the code without first collapsing to the first non-empty character gs and re-select the line remainder vgl<esc>.

It's a bit situational but I have used it organically (meaning I didn't reach for it just to practice it's usage but because it was the most natural thing that came to mind to enable what I was doing) in the past.

[archseer]

Tested locally, thanks! 🎉