Add last modified file (gm) #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudormrfbin
reviewed
Nov 14, 2021
archseer
reviewed
Nov 14, 2021
archseer
reviewed
Nov 14, 2021
helix-term/src/keymap.rs
Outdated
| @@ -520,9 +520,10 @@ impl Default for Keymaps { | |||
| "r" => goto_reference, | |||
| "i" => goto_implementation, | |||
| "t" => goto_window_top, | |||
| "m" => goto_window_middle, | |||
| "c" => goto_window_middle, | |||
There was a problem hiding this comment.
I rejected changing this keybind before :P why not find a different keymap for goto_last_modified_file?
There was a problem hiding this comment.
There are a couple of reasons
- it is the same as kakoune now
gc, and the name center works fine too - it is more aligned with view mode,
zchave the same behavior and it is named "center" not "middle",zmnamed "middle" changes the cursor horizontally, not vertically like this one - at the same time
gmfits nicely according togasince it meanslast modified fileandgameanslast accessed file
Do you have any suggestions for this?
There was a problem hiding this comment.
Not sure if we'd want to put this in the default keymap but I'd probably remap goto_last_modified_file to gM.
archseer
reviewed
Nov 14, 2021
pickfire
force-pushed
the
last-modified-file
branch
from
8133c00
to
b175420
Compare
pickfire
force-pushed
the
last-modified-file
branch
from
b175420
to
5096de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @EpocSquadron
This will change
gm(goto middle) togcbut now it matches kakoune behavior and ourzc.Based on mawww/kakoune#3814