Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helix-view): dynamic line numbers #1522

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

The0x539
Copy link
Contributor

This is a configuration that I've carried with me from Vim to Neovim to Kakoune.

This implementation was remarkably easy to figure out; in the past, it had always been unusually difficult and relied on various mode change hooks and what not.

@pickfire
Copy link
Contributor

Can I know how did you do this in vim, neovim, and kakoune?

Although this seemed useful as a default (at least from what I see given that relative number is only showing at the time it is useful), it seemed oddly specific.

@pickfire
Copy link
Contributor

I think you also need to update the book configuration.md but if you just put dynamic I doubt readers understand what it meant.

@pickfire pickfire self-requested a review January 16, 2022 15:26
@The0x539
Copy link
Contributor Author

The0x539 commented Jan 16, 2022

Can I know how did you do this in vim, neovim, and kakoune?

I'm pretty sure I originally found my original Vim version online on some "tips and tricks" wiki that I could swear was on Wikia, but I can't find it now. Maybe I'm misremembering and never had it in regular Vim; a quick search of the master (old) branch of my dotfiles repo suggests as much.

This, after some refinement, is how I did it in Neovim, and this mess, of my own invention, is how I do it in Kakoune.

I think you also need to update the book configuration.md

Yes, good catch. I'll do that now.

EDIT: I may have found it.

book/src/configuration.md Outdated Show resolved Hide resolved
@archseer
Copy link
Member

archseer commented Jan 21, 2022

Should we just make this the default behavior of relative line number? I can't imagine you'd want relative line numbers in unfocused windows so the new behavior seems a lot better

@archseer
Copy link
Member

Let's make this the default behavior of relative!

@archseer archseer merged commit 333c294 into helix-editor:master Jan 25, 2022
@The0x539 The0x539 deleted the dynamic-numbers branch January 25, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants