Add horizontal and vertical split scratch buffers

[jharrilim]

Add horizontal and vertical split scratch buffers

This change proposes the addition of two new commands to open scratch buffers in splits. It works out to be very similar to :hsplit src/newfilename.rs where newfilename.rs is a file that doesn't exist, but with the intention of not actually creating a file when you are done with it.

[archseer]

:new already splits horizontally, so you just need to add the equivalent of vim's :vnew.

[jharrilim]

:new already splits horizontally, so you just need to add the equivalent of vim's :vnew.

:new in vim splits horizontally, but in helix it replaces the current view:

helix/helix-term/src/commands.rs

Lines 2235 to 2243 in 9bfb0ca

	fn new_file(
	cx: &mut compositor::Context,
	_args: &[Cow<str>],
	_event: PromptEvent,
	) -> anyhow::Result<()> {
	cx.editor.new_file(Action::Replace);
	Ok(())
	}

Should we change :new to split horizontally then with the addition of :vnew?

[archseer]

Ah yeah, sorry I mixed it up. I'd either change :new to open a horizontal split or add :hnew.

[jharrilim]

Went with the second suggestion and changed the aliases to hnew and vnew. The flexibility is nice!

[archseer]

Sorry, one more rebase is needed: I split the typable commands out to a separate file

[jharrilim]

No problem! updated the PR

[archseer]

"Scratch buffer in new split"

I'm also not sure how I feel about these mappings, we can leave them in for now though

[pickfire]

I know doom emacs for this space w n will split vertical, not sure if we want so many layers here.

[the-mikedavis]

I am probably biased as I use the scratchpad rarely but I think this would be fine without default keybindings at all. I think the typable commands are more appropriate, especially given how many keypresses these keybindings take.

[jharrilim]

It's definitely a tad deep! My argument for keeping it in here would be that when I first installed helix and played around with it, I was very much inclined to pressing space and discovering commands through the dialog. I naturally began to start using space w to find window commands, and felt like this was an appropriate place to put them since the other split commands were here too. Once I got into the flow of navigating this way, it didn't feel too deep IMO.

[the-mikedavis]

Hmm good point, the discoverability is nice with the space popups. Although it also possible to discover things through the command picker (#1400), but I don't remember if that shows typable commands. I don't have strong feelings about the bindings, I would feel ok with these 👍

[archseer]

Thanks! 🎉