Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :write! to create nonexistent subdirectories #1839

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Add :write! to create nonexistent subdirectories #1839

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bc2b25
Make `:write` create nonexistent subdirectories
Omnikar Mar 18, 2022
7927781
Move subdirectory creation to new `w!` command
Omnikar Apr 6, 2022
71981c2
Merge branch 'master' into write-create-dirs
Omnikar Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helix-view/src/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ impl Document {
if let Some(parent) = path.parent() {
// TODO: display a prompt asking the user if the directories should be created
if !parent.exists() {
bail!("can't save file, parent directory does not exist");
std::fs::DirBuilder::new().recursive(true).create(parent)?;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should at least show a status message that new directories were created (or even better a prompt like the TODO says).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we display a status message or a prompt from this function?

}

Expand Down