Move top level lsp config to editor.lsp #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
approved these changes
Mar 26, 2022
|
Looks like the PR has some conflicts with master |
This is mainly done to accomodate the new lsp.signature-help config option that will be introduced in helix-editor#1755 which will have to be accessed by commands. The top level config struct is split and moved to different places, making the relocation necessary
sudormrfbin
force-pushed
the
move-lsp-config
branch
from
491a44b
to
f1a511b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly done to accomodate the new lsp.signature-help config option that will be introduced in #1755 which will have to be accessed by commands. The top level config struct is split and moved to different places, making the relocation necessary.