Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language server command for OCaml #2035

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Add language server command for OCaml #2035

merged 1 commit into from
Apr 8, 2022

Conversation

valpackett
Copy link
Contributor

@David-Else
Copy link
Contributor

You need to build the docs with cargo xtask docgen It shows in the failed https://github.com/helix-editor/helix/runs/5890360609?check_suite_focus=true

the-mikedavis
the-mikedavis approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Would you mind adding a note to the new lsp wiki with some notes on how one usually installs ocamllsp? https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers

@the-mikedavis the-mikedavis merged commit 7f46189 into helix-editor:master Apr 8, 2022
@valpackett valpackett deleted the patch-1 branch April 8, 2022 20:02
@valpackett
Copy link
Contributor Author

Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valpackett @David-Else @the-mikedavis