Add command to extend selection to line above #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we ensure the direction of the cursor is reverse to solve that? |
archseer
reviewed
Apr 16, 2022
helix-term/src/commands.rs
Outdated
Comment on lines
1879
to
1898
| fn extend_line_above(cx: &mut Context) { | ||
| let count = cx.count(); | ||
| let (view, doc) = current!(cx.editor); | ||
|
|
||
| let text = doc.text(); | ||
| let selection = doc.selection(view.id).clone().transform(|range| { | ||
| let (start_line, end_line) = range.line_range(text.slice(..)); | ||
|
|
||
| let mut start = text.line_to_char(start_line); | ||
| let end = text.line_to_char((end_line + count).min(text.len_lines())); | ||
|
|
||
| // go to previous line if current line is selected | ||
| if range.from() == start && range.to() == end { | ||
| start = text.line_to_char(start_line.saturating_sub(1)); | ||
| } | ||
| Range::new(end, start) | ||
| }); | ||
|
|
||
| doc.set_selection(view.id, selection); | ||
| } |
There was a problem hiding this comment.
This is a lot of duplication for essentially changing two lines. Can you factor out the common implementation in a similar way we do for other commands like https://github.com/helix-editor/helix/blob/b6e452151196bf773874d266f9bf82e7386e56ef/helix-term/src/commands.rs#L4349-L4380=
archseer
approved these changes
Apr 17, 2022
|
This should be added to the docs (with a default keybind too maybe ?). |
|
Keybinds are being discussed in #2130 (alongside a refactor of how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to
extend_line, but extends selection above rather than below.One limitation I don't quite know how to fix is that currently it doesn't scroll the view upwards once it reaches the top of the screen. I figure it's because the "main cursor" stays at the bottom of the selection, so the view does not scroll to contain the top of the selection the same way it does for the bottom.