Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nickel language #2173

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Conversation

ErinvanderVeen
Copy link
Contributor

Resolves #1809

@the-mikedavis
Copy link
Member

It looks like fun is missing a highlight. If you move this up to the top of the file and add fun it'll highlight as a keyword:

["fun" "forall" "default" "doc"] @keyword

@ErinvanderVeen
Copy link
Contributor Author

I think your review was a little early. "fun" should be highlighted, I query for fun_expr and within that for "fun".

@the-mikedavis
Copy link
Member

Ah yep I was on an old revision. I see the fun highlight now 👍

@the-mikedavis
Copy link
Member

What do you think about for a highlight of the => arrow in a function? I think in languages with similar features we've used @operator before

"=>" @operator

@ErinvanderVeen
Copy link
Contributor Author

That does sound like a good idea. I'll add that.

@ErinvanderVeen
Copy link
Contributor Author

This PR tweag/nickel#681 should land soon, adding a new rec keyword to the language, which will also involve an update to the tree-sitter grammar. It's up to you if you think it best to wait for that. I expect it will be merged before the end of this week.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@the-mikedavis
Copy link
Member

I think we'll just merge this now and the rec update can be a follow up 👍

@the-mikedavis the-mikedavis merged commit 9616477 into helix-editor:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nickel: language support (lsp, tree-siiter)
3 participants