Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark_plus: Add the borders color from the original theme #2186

Merged
merged 2 commits into from Apr 20, 2022
Merged

dark_plus: Add the borders color from the original theme #2186

merged 2 commits into from Apr 20, 2022

Conversation

korken89
Copy link
Contributor

Hi, II added the border for the rulers based on the border color of the original theme.
Without this the rulers are not shown.

the-mikedavis
the-mikedavis approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@the-mikedavis the-mikedavis merged commit 5247d3a into helix-editor:master Apr 20, 2022
@kirawi
Copy link
Member

kirawi commented Apr 22, 2022

Where did you pull the color from? I can't seem to find it when running Developer: Generate Color Theme From Current Settings in VSCode.

@korken89
Copy link
Contributor Author

@kirawi I found it here: https://github.com/samdark/intellij-visual-studio-code-dark-plus/blob/master/resources/visual_studio_code_dark_plus.theme.json#L10

@korken89 korken89 deleted the dark-plus-borders branch April 23, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@korken89 @kirawi @the-mikedavis