Prevent panic when handling an LSP response with no request #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
reviewed
May 16, 2022
pickfire
reviewed
May 16, 2022
A language server may push a response which doesn't belong to any request. With this change, we discard the response rather than crashing. In the case of helix-editor#2474, the language server sends an error message with a null request ID which should not ever exist in the `pending_requests` HashMap. closes helix-editor#2474
the-mikedavis
force-pushed
the
md-prevent-panic-on-missing-pending-request
branch
from
ecd9eb7
to
4bb33e1
Compare
Closed
archseer
approved these changes
May 17, 2022
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
…itor#2475) A language server may push a response which doesn't belong to any request. With this change, we discard the response rather than crashing. In the case of helix-editor#2474, the language server sends an error message with a null request ID which should not ever exist in the `pending_requests` HashMap. closes helix-editor#2474
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
…itor#2475) A language server may push a response which doesn't belong to any request. With this change, we discard the response rather than crashing. In the case of helix-editor#2474, the language server sends an error message with a null request ID which should not ever exist in the `pending_requests` HashMap. closes helix-editor#2474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A language server may push a response which doesn't belong to any
request. With this change, we discard the response rather than
crashing.
In the case of #2474, the language server sends an error message
with a null request ID which should not ever exist in the
pending_requestsHashMap.closes #2474