Fix panic when reloading a shrunk file #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what's up with the lints - it looks like it might be using clippy from master despite pulling in the stable rust toolchain? Even re-running the check didn't fix it 🤔 |
|
yeah maybe we should create another PR to fix those warnings |
the-mikedavis
added
the
S-waiting-on-review
archseer
reviewed
May 20, 2022
|
As for the lints, I ran |
|
It looks like rust (and clippy) 1.61.0 were released recently and the CI has already started using it. e04bb8b was just merged that fixes the lints so if you rebase on top of that, the lints CI should clear up |
pppKin
force-pushed
the
panic_reload_shrunk_file
branch
from
e1a030e
to
7570694
Compare
|
Ah, I updated my rust toolchain to 1.61 and indeed it would generate erros now. I have rebased onto latest master. |
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
* fix panic when reloading a shrunk file * linting * use scrolloff
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
* fix panic when reloading a shrunk file * linting * use scrolloff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small PR to fix #2305