Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce storage_class highlight scope #2731

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

theli-ua
Copy link
Contributor

@theli-ua theli-ua commented Jun 9, 2022

Inspired by VIM's StorageClass hi group

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer this use a hyphen: @keyword.storage-class. It shouldn't be a problem to use hyphens in the query files since they're lisp or in the theme toml

runtime/queries/rust/highlights.scm Outdated Show resolved Hide resolved
@archseer
Copy link
Member

Why not @keyword.storage?

@theli-ua
Copy link
Contributor Author

Why not @keyword.storage?

Sure, why not.

runtime/queries/rust/highlights.scm Show resolved Hide resolved
runtime/queries/rust/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/rust/highlights.scm Outdated Show resolved Hide resolved
book/src/themes.md Outdated Show resolved Hide resolved
(self_parameter "&" @keyword.storage.modifier.ref)

[
(mutable_specifier)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant since there's already a capture for this scope.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you're right. I returned mutable as an additional scope but forgot to remove it from storage.modifier

Inspired by VIM's StorageClass hi group
@the-mikedavis the-mikedavis merged commit 7983c71 into helix-editor:master Jun 14, 2022
@theli-ua theli-ua deleted the storage_class branch June 14, 2022 18:10
lazytanuki pushed a commit to lazytanuki/helix that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants