-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce storage_class highlight scope #2731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would prefer this use a hyphen: @keyword.storage-class
. It shouldn't be a problem to use hyphens in the query files since they're lisp or in the theme toml
Why not |
Sure, why not. |
runtime/queries/rust/highlights.scm
Outdated
(self_parameter "&" @keyword.storage.modifier.ref) | ||
|
||
[ | ||
(mutable_specifier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant since there's already a capture for this scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you're right. I returned mutable as an additional scope but forgot to remove it from storage.modifier
Inspired by VIM's StorageClass hi group
Inspired by VIM's StorageClass hi group