Fix expansion of ~

[vv9k]

Closes: #280

[archseer]

You still want this because paths need to be converted to absolute. Not taking current_dir() into account will consider myfile.c and /full/path/to/myfile.c as two separate files.

[archseer]

Tilde expansion should be a step before normalization: https://github.com/netvl/shellexpand/blob/e707d07a0a2638df7ab26b152f814e80ce3b3992/src/lib.rs#L665-L690

[sudormrfbin]

Autocompletion for :open isn't working yet and I think it'd be better to show the path with ~ instead of the fully expanded path in the status line.

[archseer]

The display part should be fixed by modifying this:

helix/helix-view/src/document.rs

Lines 687 to 693 in a364d6c

	pub fn relative_path(&self) -> Option<&Path> {
	let cwdir = std::env::current_dir().expect("couldn't determine current directory");
	self.path
	.as_ref()
	.map(|path| path.strip_prefix(cwdir).unwrap_or(path))
	}

[archseer]

Tested and works good, let's change doc.relative_path to replace the home path with ~ as well

[vv9k]

Tested and works good, let's change doc.relative_path to replace the home path with ~ as well

Yes, completely forgot about that one. Updated, opening home dir path now looks like this after opening the full path /home/user/dev/rust/helix/Cargo.toml:

[archseer]

No need for to_string() here, it's already a Cow I think.

[vv9k]

Unfortunatelly:

error[E0515]: cannot return value referencing function parameter `path`
    --> helix-term/src/commands.rs:1073:33
     |
1073 |                     .map(|path| path.to_string_lossy())
     |                                 ----^^^^^^^^^^^^^^^^^^
     |                                 |
     |                                 returns a value referencing data owned by the current function
     |                                 `path` is borrowed here

[vv9k]

It is a consequence of changing the return type of relative_path to be owned PathBuf not &Path but I'm not sure I can return a &Path while still folding home directory into tilde.