Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arrow keys and page up/down work in insert mode #305

Merged
merged 1 commit into from Jun 19, 2021

Conversation

vv9k
Copy link
Contributor

@vv9k vv9k commented Jun 18, 2021

Closes: #303

@cessen cessen requested a review from archseer June 18, 2021 18:58
@cessen
Copy link
Contributor

cessen commented Jun 18, 2021

I think @archseer had some concerns about this (IIRC, not in principle, just that it might interfere with how something else is implemented right now), so I've added him as reviewer.

But I'm all for this change. This is actually one of the major blockers for me using Helix as my daily driver. My muscle memory is just too used to being able to move the cursor at any time, regardless of mode.

@robinvd
Copy link
Contributor

robinvd commented Jun 18, 2021

I think #84 is the same issue

@cessen
Copy link
Contributor

cessen commented Jun 19, 2021

Discussed with @archseer, and did some testing to make sure everything works. It all seems to work without problems. So, approved!

@cessen cessen self-requested a review June 19, 2021 04:36
@cessen cessen merged commit 1c25852 into helix-editor:master Jun 19, 2021
@vv9k
Copy link
Contributor Author

vv9k commented Jun 19, 2021

I probably should have added home and end while I was at it, I'll send another PR

@itzmjauz
Copy link
Contributor

I probably should have added home and end while I was at it, I'll send another PR

Please do! :) All #84 needed was for me to close it!

@vv9k
Copy link
Contributor Author

vv9k commented Jun 19, 2021

Please do! :) All #84 needed was for me to close it!

Submitted #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make arrow keys work in insert mode
4 participants