read only indicator #3709
Closed
read only indicator #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want read-only indicators in bufferline as well? It's an easy add. |
archseer
reviewed
Sep 6, 2022
Comment on lines
+402
to
+410
| // this seems overly complex but should make it easier | ||
| // to extend doc.file_stat with more information in the future. | ||
| doc.write_permission = fs::metadata(path).map_or(WritePermission::Unknown, |f| { | ||
| if f.permissions().readonly() { | ||
| WritePermission::ReadOnly | ||
| } else { | ||
| WritePermission::Writable | ||
| } | ||
| }); |
There was a problem hiding this comment.
Should probably be part of doc.set_path since a path can also be changed after opening?
There was a problem hiding this comment.
What are the implications of changing a path after opening?
|
Why did the author close this without any info? |
|
Does anyone know if there's work ongoing for a read-only indicator, or a read-only flag/option for buffers? I can't find any info about why this PR was closed or anything happening after it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #2862.